tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

Create and Initialize RPacketLastInteractionClass #2650

Closed Sumit112192 closed 2 months ago

Sumit112192 commented 3 months ago

:pencil: Description

Type: :roller_coaster: restructure We need to merge PR #2690 first. This PR introduces a new class, RPacketLastInteractionTracker, which is similar to the RPacketTraker but only stores the last interaction info.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (9aec7a7) to head (e6c6e2d). Report is 6 commits behind head on master.

:exclamation: Current head e6c6e2d differs from pull request most recent head 357cba9

Please upload reports for the commit 357cba9 to get more accurate results.

Files Patch % Lines
tardis/transport/montecarlo/packet_trackers.py 29.41% 12 Missing :warning:
...ardis/transport/montecarlo/montecarlo_main_loop.py 25.00% 3 Missing :warning:
tardis/transport/montecarlo/single_packet_loop.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2650 +/- ## ========================================== + Coverage 67.89% 67.94% +0.04% ========================================== Files 174 175 +1 Lines 14439 14513 +74 ========================================== + Hits 9804 9861 +57 - Misses 4635 4652 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (9aec7a7073f8ee8631d2c3d63b7449ec773ef56c) and the latest commit (357cba9a99af55a9b7c11f91449f2d50e639ef4a). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
tardis-bot commented 3 months ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

Sumit112192 commented 2 months ago

PR #2716 used this PR's work to implement LastInteractionTracker. Closing This PR.