Closed andrewfullard closed 3 weeks ago
What really needs to happen to resolve the CSVY bug (and may happen in this PR?) is to remove all loc[1:]
calls across the I/O part of the code and take stock of how we really want to read in tables of densities, mass fractions, etc
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
*beep* *bop*
Hi, human.
The docs
workflow has succeeded :heavy_check_mark:
Click here to see your results.
@jvshields pluralized instances of mass_fraction in this PR. The Composition class still has lots of singular form.
:pencil: Description
Type: :roller_coaster:
infrastructure
This PR refactors the I/O part of TARDIS to split it up better by category e.g. Composition (and its parts).
Also fixes bug with CSVY dimensions
Fixes #2582
:vertical_traffic_light: Testing
How did you test these changes?
:ballot_box_with_check: Checklist
build_docs
label