tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 402 forks source link

I/O Refactoring #2652

Closed andrewfullard closed 3 weeks ago

andrewfullard commented 1 month ago

:pencil: Description

Type: :roller_coaster: infrastructure

This PR refactors the I/O part of TARDIS to split it up better by category e.g. Composition (and its parts).

Also fixes bug with CSVY dimensions

Fixes #2582

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

andrewfullard commented 1 month ago

What really needs to happen to resolve the CSVY bug (and may happen in this PR?) is to remove all loc[1:] calls across the I/O part of the code and take stock of how we really want to read in tables of densities, mass fractions, etc

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

tardis-bot commented 1 month ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

andrewfullard commented 3 weeks ago

@jvshields pluralized instances of mass_fraction in this PR. The Composition class still has lots of singular form.