tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

fix benchmark action #2656

Closed officialasishkumar closed 3 months ago

officialasishkumar commented 3 months ago

:pencil: Description

Type: :beetle: 🚀

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 months ago

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (e88a31a809eb041068fffeeb16e1585b8e51f3a5) and the latest commit (5d5e93c171f4cdb4f267855b1f043ea689ebfdfa). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
andrewfullard commented 3 months ago

Please test by making a version on your fork and add link to test results here

officialasishkumar commented 3 months ago

Please test by making a version on your fork and add link to test results here

https://github.com/AkashKumar7902/tardis/actions/runs/9705432873/job/26787490302?pr=6

the error in the later half is due to the generation of file which is relying upon tardis repo. The compare is working which means the bot will display the comparision output.

andrewfullard commented 3 months ago

Please test by making a version on your fork and add link to test results here

https://github.com/AkashKumar7902/tardis/actions/runs/9705432873/job/26787490302?pr=6

the error in the later half is due to the generation of file which is relying upon tardis repo. The compare is working which means the bot will display the comparision output.

image

Is there an excess step here?

officialasishkumar commented 3 months ago

Yes, that's an extra step. I have removed it.

here is the new action run: https://github.com/officialasishkumar/tardis/actions/runs/9733397076/job/26860263830?pr=12

jvshields commented 3 months ago

This may be helpful - https://stackoverflow.com/questions/61393981/getting-base-branch-sha-on-pull-request-in-github-action-workflow

officialasishkumar commented 3 months ago

https://github.com/sympy/sympy/blob/master/.github/workflows/runtests.yml

cc: @andrewfullard @atharva-2001

atharva-2001 commented 3 months ago

Yes, that's an extra step. I have removed it.

here is the new action run: officialasishkumar/tardis/actions/runs/9733397076/job/26860263830?pr=12

This workflow used this workflow file- https://github.com/officialasishkumar/tardis/actions/runs/9733397076/workflow?pr=12 which does not have your commits. Is the workflow being correctly tested? Note that these are pull request target workflows, so they will only pick the workflow file from the target(master) branch, not from the pull request branch.

officialasishkumar commented 3 months ago

Note that these are pull request target workflows, so they will only pick the workflow file from the target(master) branch, not from the pull request branch.

Here is the new workflow run: https://github.com/officialasishkumar/tardis/actions/runs/9746049892/job/26895430197?pr=13 Here is the master branch benchmarks.yml that was updated yesterday: https://github.com/officialasishkumar/tardis/blob/master/.github/workflows/benchmarks.yml

atharva-2001 commented 3 months ago

The workflow runs on this commit- https://github.com/officialasishkumar/tardis/tree/bff68859d97a0764e38e5e598c48940e748e45a9

Not the master branch as far as I understand.

Click on the workflow file on the left side of this page- https://github.com/officialasishkumar/tardis/actions/runs/9746049892/job/26895430197?pr=13

then click on commit hash, then browse files, and you will see this https://github.com/officialasishkumar/tardis/tree/bff68859d97a0764e38e5e598c48940e748e45a9

officialasishkumar commented 3 months ago

@atharva-2001, the workflow file might be because my branch is not really updated with master for a while (approx 2 months). I think the workflow is running with the current master branch as you can see in the build that the jobs that are runned are aligned with the current changes and not the old one.