tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

Add attributes specific to line interaction in the Tracker classes. #2662

Closed Sumit112192 closed 2 months ago

Sumit112192 commented 3 months ago

:pencil: Description

Type: :roller_coaster: restructure

PR #2650 needs to be merged first before this PR. This PR introduces Line attributes to tracker classes.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (9aec7a7073f8ee8631d2c3d63b7449ec773ef56c) and the latest commit (02b845a6f98e5aa618f4ebb7cffa74e38ccf7728). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
wkerzendorf commented 2 months ago

@Sumit112192 this should be closed, right?

Sumit112192 commented 2 months ago

@Sumit112192 this should be closed, right?

Yes. Closing.