[Restructure/plasma] Refactor the simulation state initialization

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

198 stars 403 forks source link

[Restructure/plasma] Refactor the simulation state initialization #2664

Open wkerzendorf opened 3 weeks ago

wkerzendorf commented 3 weeks ago

Is based on the restructure radiation field PR. #2613

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tardis-bot commented 3 weeks ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

andrewfullard commented 3 weeks ago

The general idea is good but I feel like we are back in parse_input territory, same as with the I/O before my refactoring. The top-level modules (atom data, plasma, transport etc) should be initialized in separate files with all their associated functions.