tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 402 forks source link

Add arm64 conda-lock file #2667

Closed atharva-2001 closed 6 days ago

atharva-2001 commented 3 weeks ago

:pencil: Description

Type: :rocket: feature :vertical_traffic_light: testing | :roller_coaster: infrastructure

Adds lock file for osx-64. Made on top of #2666 so that will need to be merged earlier so that diff can be seen easily.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 weeks ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (e88a31a809eb041068fffeeb16e1585b8e51f3a5) and the latest commit (ca2fa36b312da03cc29b9eeccfab32d7aafaabf0). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
tardis-bot commented 3 weeks ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

andrewfullard commented 3 weeks ago

I don't have an arm-64 machine to test this. I know @wkerzendorf did. @jvshields can you test this on your Mac?

wkerzendorf commented 3 weeks ago

@andrewfullard I did - works well

wkerzendorf commented 3 weeks ago

@atharva-2001 you need to resolve conflicts

andrewfullard commented 2 weeks ago

The tests don't appear to be running

atharva-2001 commented 1 week ago

They're running now. The osx-64-pip-true Expected — Waiting for status to be reported will appear on the pull request since that is a required check and I recently changed the name, I'll fix that once the pull request is merged.

atharva-2001 commented 1 week ago

The tests passed with the new lock file. https://github.com/tardis-sn/tardis/actions/runs/9790952450/job/27033669200?pr=2667 I'm undoing the changes now.