R packet tracker fix - Githubissues

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

202 stars 405 forks source link

R packet tracker fix #2672

Closed Sumit112192 closed 3 months ago

Sumit112192 commented 3 months ago

:pencil: Description

Type: :beetle: bugfix Fixes #2671 This PR fixes the way RPacketTracker tracks the packet. Also, since no tests were written for rpacket_tracker. I wrote some of them.

:vertical_traffic_light: Testing

How did you test these changes? pytest -vvs tardis/transport/montecarlo/tests/test_rpacket_tracker.py --tardis-refdata=/home/sam/TARDIS/tardis-refdata

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor. @wkerzendorf @andrewfullard

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (26b60059dfd0cad0c2651d52137e45b609c696e8) and the latest commit (595d64054b60c70b5d2d566a83604952deca0d45). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```

tardis-bot commented 3 months ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.79518% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.36%. Comparing base (9aec7a7) to head (595d640). Report is 8 commits behind head on master.

Files	Patch %	Lines
tardis/transport/montecarlo/single_packet_loop.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2672 +/- ## ========================================== + Coverage 67.89% 69.36% +1.46% ========================================== Files 174 179 +5 Lines 14439 14315 -124 ========================================== + Hits 9804 9930 +126 + Misses 4635 4385 -250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.