Energy input benchmark - Githubissues

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

198 stars 402 forks source link

Energy input benchmark #2673

Open officialasishkumar opened 3 weeks ago

officialasishkumar commented 3 weeks ago

:pencil: Description

Type: :rocket: feature

Benchmark for energy input functions

[x] Benchmark for run_gamma_ray_loop
[x] Benchmark for gamma_packet_loop

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 weeks ago

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot commented 3 weeks ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (26b60059dfd0cad0c2651d52137e45b609c696e8) and the latest commit (0f751cee92d5631da7a78154aa290b2f4039ebba). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```

andrewfullard commented 3 weeks ago

Please provide test results here

atharva-2001 commented 1 day ago

@officialasishkumar is this done?

officialasishkumar commented 1 day ago

I was told to stop working on this since there is some ongoing modification in the energy input files.