tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 402 forks source link

Fix missing atom data error in benchmark action #2674

Closed KasukabeDefenceForce closed 1 week ago

KasukabeDefenceForce commented 3 weeks ago

:pencil: Description

Type: :beetle: bugfix

The benchmarks workflow throws an error where it could find the atomic data. Copying atomic data to that specific directory will fix that issue

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 weeks ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (26b60059dfd0cad0c2651d52137e45b609c696e8) and the latest commit (7818505770096fac8a591610eb26a9455e5aa6fb). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
andrewfullard commented 3 weeks ago

Can you show the results from your fork?

atharva-2001 commented 1 week ago

I think this has been addressed in https://github.com/tardis-sn/tardis/pull/2656, so we can close this I'm afraid