tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

Overload approach #2687

Closed Sumit112192 closed 3 months ago

Sumit112192 commented 3 months ago

:pencil: Description

Type: :roller_coaster: infrastructure This PR combines PR #2680 and PR #2672 to see if the numba overload function works in TARDIS.

Post1) https://numba.discourse.group/t/passing-config-variables-to-functions-so-they-behave-as-compile-time-constants/2619/6 Post2)https://numba.discourse.group/t/how-to-avoid-multiple-overload-functions-for-the-same-config-variable/2625

Question on Stack overflow https://stackoverflow.com/questions/78675748/passing-config-variables-to-functions-so-they-behave-as-compile-time-constants/78680194?noredirect=1#comment138734245_78680194

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 77.54011% with 42 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (0df98ce) to head (263140c). Report is 3 commits behind head on master.

:exclamation: Current head 263140c differs from pull request most recent head 79420d6

Please upload reports for the commit 79420d6 to get more accurate results.

Files Patch % Lines
tardis/transport/montecarlo/single_packet_loop.py 11.11% 16 Missing :warning:
...ntecarlo/overload_utils/ENABLE_RPACKET_TRACKING.py 69.76% 13 Missing :warning:
...ardis/transport/montecarlo/montecarlo_main_loop.py 15.38% 11 Missing :warning:
...s/transport/montecarlo/montecarlo_configuration.py 93.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2687 +/- ## ========================================== + Coverage 67.80% 69.48% +1.67% ========================================== Files 177 180 +3 Lines 14534 14398 -136 ========================================== + Hits 9855 10004 +149 + Misses 4679 4394 -285 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.