search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 403 forks source link

Spectrum refactor #2689

Open andrewfullard opened 2 weeks ago

andrewfullard commented 2 weeks ago

:pencil: Description

Type: :biohazard: breaking change

This PR moves as much of the spectrum out of the transport state as possible without also factoring out virtual packets.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

andrewfullard commented 2 weeks ago

Current issue: need to move and regenerate reference/regression data.

andrewfullard commented 1 week ago

Test failures are expected until https://github.com/tardis-sn/tardis-refdata/pull/85 and https://github.com/tardis-sn/tardis-regression-data/pull/8 are merged.

tardis-bot commented 1 week ago

*beep* *bop*

Hi, human.

The docs workflow has failed :x:

Click here to see the build log.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 18 minutes ago

Codecov Report

Attention: Patch coverage is 50.00000% with 56 lines in your changes missing coverage. Please review.

Project coverage is 36.50%. Comparing base (c107f27) to head (e8aebcc).

Files Patch % Lines
tardis/spectrum/base.py 50.00% 31 Missing :warning:
tardis/simulation/base.py 20.00% 12 Missing :warning:
tardis/tests/test_tardis_full.py 44.44% 5 Missing :warning:
tardis/tests/test_tardis_full_formal_integral.py 57.14% 3 Missing :warning:
tardis/spectrum/tests/test_cuda_formal_integral.py 71.42% 2 Missing :warning:
tardis/visualization/widgets/line_info.py 0.00% 2 Missing :warning:
tardis/transport/montecarlo/base.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2689 +/- ## ========================================== + Coverage 36.47% 36.50% +0.03% ========================================== Files 183 184 +1 Lines 14664 14684 +20 ========================================== + Hits 5348 5361 +13 - Misses 9316 9323 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.