Benchmark fix for github actions

officialasishkumar commented 3 months ago

:pencil: Description

Type: :beetle: bugfix

Fixes the current action

:pushpin: Resources

https://github.com/officialasishkumar/tardis/actions/runs/9911989050/job/27385842897 (This will take some time to complete)
ran on https://github.com/tardis-sn/tardis/compare/master...officialasishkumar:tardis:master (i.e. the changes on this PR)

Note: Just for surety before merging we should wait for the action to finish.

This is how i checked it prior to the creation of this PR:

I ran it in chunks just to save some time. For the first time, run_tardis failed for some reasons in actions but others passed https://github.com/officialasishkumar/tardis/actions/runs/9910265728/job/27380239908

and the second time after fix, i only ran run_tardis whose actions can be found at https://github.com/officialasishkumar/tardis/actions/runs/9783164239/job/27011119081 which passed

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.38%. Comparing base (17b1da4) to head (2cc765a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2702 +/- ## ======================================= Coverage 38.38% 38.38% ======================================= Files 181 181 Lines 14471 14471 ======================================= Hits 5554 5554 Misses 8917 8917 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewfullard commented 3 months ago

Good work, appears to be functioning on your fork. The benchmarks taking more than an hour is probably a bad sign though!

atharva-2001 commented 3 months ago

Looks fine to me too.

tardis-sn / tardis