tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
201 stars 404 forks source link

Add google analytics key to tardis docs #2709

Closed KasukabeDefenceForce closed 1 month ago

KasukabeDefenceForce commented 1 month ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

Add google analytics to tardis docs

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 1 month ago

*beep* *bop*

Hi, human.

The docs workflow has failed :x:

Click here to see the build log.

atharva-2001 commented 1 month ago

The docs failed for some reason. We should already have sphinx, right? The google analytics is only thing that is not in the environment

KasukabeDefenceForce commented 1 month ago

The docs failed for some reason. We should already have sphinx, right? The google analytics is only thing that is not in the environment

There is some issue with actions, because it is not running the steps to install the google analytics extension even though the workflow file has that step. YOu can see the workflow file and notice that there is one step missing here before the build docs step (https://github.com/tardis-sn/tardis/actions/runs/9957918456/job/27513537830?pr=2709)

atharva-2001 commented 1 month ago

That is because this is a pull_request_target event workflow. Edit the workflow triggers and make it work on your fork. Once it runs you can share a link here and undo the steps so that just the relevant ones remain.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.47%. Comparing base (c107f27) to head (eec1c6b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2709 +/- ## ======================================= Coverage 36.47% 36.47% ======================================= Files 183 183 Lines 14664 14664 ======================================= Hits 5348 5348 Misses 9316 9316 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KasukabeDefenceForce commented 1 month ago

That is because this is a pull_request_target event workflow. Edit the workflow triggers and make it work on your fork. Once it runs you can share a link here and undo the steps so that just the relevant ones remain.

https://github.com/KasukabeDefenceForce/tardis/actions/runs/10004874599/job/27654456837?pr=31 Is this what you asked for?