search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
204 stars 406 forks source link

Remove `rpacket_tracking` flag from tests workflow #2746

Closed atharva-2001 closed 1 month ago

atharva-2001 commented 4 months ago

:pencil: Description

Type: :vertical_traffic_light: testing | :roller_coaster: infrastructure

Removes the rpacket_tracking flag from workflows.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

andrewfullard commented 3 months ago

This also needs to be removed from the relevant tests, correct?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.70%. Comparing base (2aa6732) to head (0ec4608). Report is 21 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2746 +/- ## ========================================== - Coverage 70.89% 70.70% -0.20% ========================================== Files 209 213 +4 Lines 15589 15821 +232 ========================================== + Hits 11052 11186 +134 - Misses 4537 4635 +98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-bot commented 2 months ago

*beep* *bop* Hi human, I ran ruff on the latest commit (0ec46084cb4f91f769e310e07dba1efbdeaea027). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 45 W293 [*] Blank line contains whitespace 31 W291 [*] Trailing whitespace 26 E999 [ ] SyntaxError: Expected ',', found ':' 25 F401 [*] `astropy.units` imported but unused 18 G004 [ ] Logging statement uses f-string 18 UP008 [*] Use `super()` instead of `super(__class__, self)` 16 I001 [*] Import block is un-sorted or un-formatted 14 E902 [ ] No such file or directory (os error 2) 10 RET505 [ ] Unnecessary `elif` after `return` statement 8 E402 [ ] Module level import not at top of cell 8 F405 [ ] `HiddenPlasmaProperty` may be undefined, or defined from star imports 6 D202 [*] No blank lines allowed after function docstring (found 1) 6 UP015 [*] Unnecessary open mode parameters 6 UP032 [*] Use f-string instead of `format` call 5 E722 [ ] Do not use bare `except` 4 E701 [ ] Multiple statements on one line (colon) 4 E712 [*] Avoid equality comparisons to `True`; use `if latex_label:` for truth checks 3 RET506 [ ] Unnecessary `else` after `raise` statement 2 C416 [*] Unnecessary `list` comprehension (rewrite using `list()`) 2 PIE808 [*] Unnecessary `start` argument in `range` 2 FLY002 [*] Consider `f"{hash_string}_{nlte_prop}"` instead of string join 2 W292 [*] No newline at end of file 2 F403 [ ] `from tardis.plasma.properties.base import *` used; unable to detect undefined names 2 F811 [*] Redefinition of unused `npt` from line 2 1 S605 [ ] Starting a process with a shell: seems safe, but may be changed in the future; consider rewriting without `shell` 1 FA102 [*] Missing `from __future__ import annotations`, but uses PEP 604 union 1 G001 [ ] Logging statement uses `str.format` 1 F821 [ ] Undefined name `s1` 1 PGH004 [ ] Use specific rule codes when using `noqa` 1 UP004 [*] Class `NLTEExcitationData` inherits from `object` 1 UP009 [*] UTF-8 encoding declaration is unnecessary 1 UP030 [*] Use implicit references for positional format fields 1 UP034 [*] Avoid extraneous parentheses 1 TRY300 [ ] Consider moving this statement to an `else` block ```

Complete output(might be large):

```diff .github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression .github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:81:49: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:111:81: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:112:54: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:199:1: W293 [*] Blank line contains whitespace .github/workflows/benchmarks.yml:218:22: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:219:170: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:221:84: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:238:1: W293 [*] Blank line contains whitespace .github/workflows/codespell.yml:3:4: E999 SyntaxError: Expected an expression .github/workflows/codespell.yml:18:11: E701 Multiple statements on one line (colon) .github/workflows/codespell.yml:39:26: W292 [*] No newline at end of file .github/workflows/codestyle.yml:7:4: E999 SyntaxError: Expected an expression .github/workflows/codestyle.yml:25:11: E701 Multiple statements on one line (colon) .github/workflows/codestyle.yml:30:11: E701 Multiple statements on one line (colon) .github/workflows/codestyle.yml:46:8: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:63:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:65:15: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:69:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:78:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:82:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:90:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:102:26: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:106:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:114:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:125:22: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:126:89: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:128:84: W291 [*] Trailing whitespace .github/workflows/codestyle.yml:144:1: W293 [*] Blank line contains whitespace .github/workflows/codestyle.yml:148:1: W293 [*] Blank line contains whitespace .github/workflows/release.yml:7:4: E999 SyntaxError: Expected an expression .github/workflows/release.yml:16:7: E701 Multiple statements on one line (colon) .github/workflows/release.yml:57:1: W293 [*] Blank line contains whitespace .github/workflows/release.yml:59:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:3:4: E999 SyntaxError: Expected an expression .github/workflows/stardis-tests.yml:22:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:39:11: W291 [*] Trailing whitespace .github/workflows/stardis-tests.yml:51:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:58:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:64:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:69:1: W293 [*] Blank line contains whitespace .github/workflows/stardis-tests.yml:75:32: W291 [*] Trailing whitespace .github/workflows/stardis-tests.yml:76:20: W292 [*] No newline at end of file .github/workflows/tests.yml:7:4: E999 SyntaxError: Expected an expression .mailmap:1:38: E999 SyntaxError: Expected an expression CHANGELOG.md:4:15: E999 SyntaxError: Expected ',', found ':' CITATION.cff:3:1: E999 SyntaxError: Invalid annotated assignment target README.rst:1:1: E999 SyntaxError: Expected a statement README_TEMPLATE.rst:1:1: E999 SyntaxError: Expected a statement conda-linux-64.lock:5:1: E999 SyntaxError: Expected class, function definition or async function definition after decorator conda-lock.yml:14:10: E999 SyntaxError: Expected an expression conda-osx-64.lock:5:1: E999 SyntaxError: Expected class, function definition or async function definition after decorator conda-osx-arm64.lock:5:1: E999 SyntaxError: Expected class, function definition or async function definition after decorator docs/_static/ruff_badge.json:1:1: E902 No such file or directory (os error 2) docs/conf.py:1:1: UP009 [*] UTF-8 encoding declaration is unnecessary docs/conf.py:27:1: I001 [*] Import block is un-sorted or un-formatted docs/conf.py:30:8: F401 [*] `tardis` imported but unused docs/conf.py:36:43: PGH004 Use specific rule codes when using `noqa` docs/conf.py:46:6: UP015 [*] Unnecessary open mode parameters docs/conf.py:67:1: F405 `exclude_patterns` may be undefined, or defined from star imports docs/conf.py:68:1: F405 `exclude_patterns` may be undefined, or defined from star imports docs/conf.py:69:1: F405 `exclude_patterns` may be undefined, or defined from star imports docs/conf.py:70:1: F405 `exclude_patterns` may be undefined, or defined from star imports docs/conf.py:71:1: F405 `exclude_patterns` may be undefined, or defined from star imports docs/conf.py:138:1: W293 Blank line contains whitespace docs/conf.py:173:1: W293 Blank line contains whitespace docs/conf.py:190:13: UP030 Use implicit references for positional format fields docs/conf.py:190:13: UP032 [*] Use f-string instead of `format` call docs/conf.py:217:1: E402 Module level import not at top of file docs/conf.py:290:4: E712 Avoid equality comparisons to `True`; use `if toml_config_tool_dict["tardis"]['edit_on_github']:` for truth checks docs/conf.py:351:1: E402 Module level import not at top of file docs/conf.py:366:10: UP015 [*] Unnecessary open mode parameters, use ""w"" docs/conf.py:381:10: UP015 [*] Unnecessary open mode parameters, use ""w"" docs/contributing/development/code_quality.rst:1:1: E999 SyntaxError: Expected an expression docs/contributing/development/developer_faq.rst:1:1: E999 SyntaxError: Expected an expression docs/contributing/development/developer_faq.rst:13:40: W291 [*] Trailing whitespace docs/contributing/development/known_projects.inc:1:1: E999 SyntaxError: Expected a statement docs/contributing/tools/hdf_writer.ipynb:cell 3:9:1: W293 [*] Blank line contains whitespace docs/contributing/tools/hdf_writer.ipynb:cell 8:3:11: E999 SyntaxError: Simple statements must be separated by newlines or semicolons docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:1:8: F401 [*] `tardis` imported but unused docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:5:38: F401 [*] `tardis.io.atom_data.base.AtomData` imported but unused docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:7:20: F811 [*] Redefinition of unused `run_tardis` from cell 2, line 2 docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:11:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:11:1: I001 [*] Import block is un-sorted or un-formatted docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:12:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:13:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:13:30: F401 [*] `astropy.units` imported but unused docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:14:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:15:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 2:16:1: E402 Module level import not at top of cell docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:2:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:8:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:12:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:17:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:22:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:24:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:26:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:32:21: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:35:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:37:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:44:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:54:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:57:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:63:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:68:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 4:75:5: RET505 Unnecessary `elif` after `return` statement docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:1:32: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:2:35: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:3:37: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:4:41: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:5:31: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:6:31: W291 [*] Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:8:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:11:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:13:112: W291 Trailing whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:15:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:49:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:54:33: UP032 [*] Use f-string instead of `format` call docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:56:33: UP032 [*] Use f-string instead of `format` call docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 7:57:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 8:9:6: UP015 [*] Unnecessary open mode parameters docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 8:12:6: UP015 [*] Unnecessary open mode parameters docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 8:16:19: C416 Unnecessary `list` comprehension (rewrite using `list()`) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 8:17:23: C416 Unnecessary `list` comprehension (rewrite using `list()`) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 9:2:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 9:4:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 9:11:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:2:5: D202 [*] No blank lines allowed after function docstring (found 1) docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:4:1: W293 Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:18:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:30:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:44:1: W293 [*] Blank line contains whitespace docs/contributing/tools/profiling/tardis_profiling_threads.ipynb:cell 10:45:43: UP032 [*] Use f-string instead of `format` call docs/index.rst:1:1: E999 SyntaxError: Expected a statement docs/index.rst:21:51: W291 [*] Trailing whitespace docs/index.rst:43:76: W291 [*] Trailing whitespace docs/index.rst:44:64: W291 [*] Trailing whitespace docs/index.rst:45:71: W291 [*] Trailing whitespace docs/index.rst:46:69: W291 [*] Trailing whitespace docs/index.rst:47:68: W291 [*] Trailing whitespace docs/index.rst:66:1: W293 [*] Blank line contains whitespace docs/index.rst:79:1: W293 [*] Blank line contains whitespace docs/index.rst:102:1: W293 [*] Blank line contains whitespace docs/io/configuration/components/models/converters/arepo_to_tardis.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted docs/io/configuration/components/models/converters/arepo_to_tardis.ipynb:cell 6:1:17: F401 [*] `numpy` imported but unused docs/io/configuration/components/models/converters/arepo_to_tardis.ipynb:cell 6:4:8: F401 [*] `json` imported but unused docs/io/configuration/components/models/csvy_full_rad.csvy:1:4: E999 SyntaxError: Expected an expression docs/physics/plasma/detailed_balance/collisional_rate_coefficients.hdf:1:1: E902 No such file or directory (os error 2) docs/physics/plasma/detailed_balance/comparison.ipynb:1:1: E902 No such file or directory (os error 2) docs/physics/plasma/detailed_balance/rates.ipynb:1:1: E902 No such file or directory (os error 2) docs/physics/plasma/detailed_balance/test_continuum_template_wkerzen_rate_coeffs.yml:1:1: E902 No such file or directory (os error 2) docs/physics/tardisgamma/index.rst:1:1: E902 No such file or directory (os error 2) docs/physics/tardisgamma/packetinitialization.rst:1:1: E902 No such file or directory (os error 2) docs/resources/code_comparison/toy_models/blondin_compare.csvy:1:4: E999 SyntaxError: Expected an expression docs/resources/code_comparison/toy_models/blondin_compare_01.csvy:1:4: E999 SyntaxError: Expected an expression docs/resources/code_comparison/toy_models/blondin_compare_06.csvy:1:4: E999 SyntaxError: Expected an expression docs/resources/credits.rst:1:1: E999 SyntaxError: Expected a statement tardis/energy_input/util.py:383:5: RET505 Unnecessary `elif` after `return` statement tardis/io/model/parse_radiation_field_configuration.py:118:13: G004 Logging statement uses f-string tardis/model/matter/composition.py:206:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/__init__.py:2:63: W291 Trailing whitespace tardis/plasma/__init__.py:5:32: F401 `tardis.plasma.base.BasePlasma` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/assembly/base.py:132:22: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union tardis/plasma/base.py:11:1: F403 `from tardis.plasma.properties.base import *` used; unable to detect undefined names tardis/plasma/base.py:45:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/base.py:46:18: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/base.py:53:9: RET506 Unnecessary `else` after `raise` statement tardis/plasma/base.py:54:18: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/base.py:111:17: E722 Do not use bare `except` tardis/plasma/base.py:144:44: F405 `PreviousIterationProperty` may be undefined, or defined from star imports tardis/plasma/base.py:153:46: F405 `Input` may be undefined, or defined from star imports tardis/plasma/base.py:273:13: G004 Logging statement uses f-string tardis/plasma/base.py:296:20: F401 [*] `pygraphviz` imported but unused tardis/plasma/base.py:297:9: E722 Do not use bare `except` tardis/plasma/base.py:306:16: E712 Avoid equality comparisons to `True`; use `if latex_label:` for truth checks tardis/plasma/base.py:327:16: E712 Avoid equality comparisons to `True`; use `if latex_label:` for truth checks tardis/plasma/base.py:333:16: E712 Avoid equality comparisons to `True`; use `if latex_label:` for truth checks tardis/plasma/base.py:383:9: E722 Do not use bare `except` tardis/plasma/base.py:429:35: F405 `HiddenPlasmaProperty` may be undefined, or defined from star imports tardis/plasma/base.py:447:29: E722 Do not use bare `except` tardis/plasma/detailed_balance/__init__.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/rates/__init__.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/rates/collision_strengths.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/rates/collisional_rates.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/rates/radiative_rates.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/tests/__init__.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/detailed_balance/tests/test_collisional_transitions.py:1:1: E902 No such file or directory (os error 2) tardis/plasma/properties/atomic.py:6:28: F401 [*] `radioactivedecay` imported but unused tardis/plasma/properties/atomic.py:11:33: F401 [*] `tardis.constants` imported but unused tardis/plasma/properties/atomic.py:379:17: UP032 [*] Use f-string instead of `format` call tardis/plasma/properties/atomic.py:558:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/properties/atomic.py:589:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/properties/atomic.py:602:17: G004 Logging statement uses f-string tardis/plasma/properties/atomic.py:643:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/properties/base.py:78:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/base.py:117:25: G004 Logging statement uses f-string tardis/plasma/properties/base.py:135:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/base.py:163:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/base.py:178:9: RET505 Unnecessary `else` after `return` statement tardis/plasma/properties/continuum_processes/__init__.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/properties/continuum_processes/__init__.py:2:5: F401 `tardis.plasma.properties.continuum_processes.photo_ion_rate_coeff.PhotoIonRateCoeff` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/properties/continuum_processes/__init__.py:4:1: F403 `from tardis.plasma.properties.continuum_processes.rates import *` used; unable to detect undefined names tardis/plasma/properties/continuum_processes/__init__.py:6:5: F401 `tardis.plasma.properties.continuum_processes.recomb_rate_coeff.StimRecombRateFactor` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/properties/continuum_processes/__init__.py:7:5: F401 `tardis.plasma.properties.continuum_processes.recomb_rate_coeff.SpontRecombRateCoeff` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/properties/continuum_processes/__init__.py:8:5: F401 `tardis.plasma.properties.continuum_processes.recomb_rate_coeff.StimRecombRateCoeff` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/properties/continuum_processes/fast_array_util.py:3:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/properties/general.py:4:30: F401 [*] `astropy.units` imported but unused tardis/plasma/properties/general.py:33:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/general.py:74:21: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/general.py:118:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/helium_nlte.py:53:13: UP034 [*] Avoid extraneous parentheses tardis/plasma/properties/helium_nlte.py:130:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/helium_nlte.py:182:21: E722 Do not use bare `except` tardis/plasma/properties/helium_nlte.py:185:29: G004 Logging statement uses f-string tardis/plasma/properties/helium_nlte.py:218:23: S605 Starting a process with a shell: seems safe, but may be changed in the future; consider rewriting without `shell` tardis/plasma/properties/helium_nlte.py:235:18: UP015 [*] Unnecessary open mode parameters tardis/plasma/properties/helium_nlte.py:238:36: PIE808 [*] Unnecessary `start` argument in `range` tardis/plasma/properties/helium_nlte.py:261:69: F821 Undefined name `s1` tardis/plasma/properties/ion_population.py:206:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/ion_population.py:291:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/ion_population.py:370:25: G004 Logging statement uses f-string tardis/plasma/properties/ion_population.py:424:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/ion_population.py:495:25: G004 Logging statement uses f-string tardis/plasma/properties/level_population.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/properties/level_population.py:28:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/nlte.py:2:8: F401 [*] `os` imported but unused tardis/plasma/properties/nlte.py:4:17: F401 [*] `numpy` imported but unused tardis/plasma/properties/nlte.py:10:53: F401 [*] `tardis.plasma.properties.ion_population.PhiSahaNebular` imported but unused tardis/plasma/properties/nlte_excitation_data.py:8:26: UP004 [*] Class `NLTEExcitationData` inherits from `object` tardis/plasma/properties/nlte_rate_equation_solver.py:302:25: UP032 [*] Use f-string instead of `format` call tardis/plasma/properties/nlte_rate_equation_solver.py:302:25: G001 Logging statement uses `str.format` tardis/plasma/properties/nlte_rate_equation_solver.py:311:25: G004 Logging statement uses f-string tardis/plasma/properties/partition_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/properties/partition_function.py:145:9: RET505 Unnecessary `elif` after `return` statement tardis/plasma/properties/partition_function.py:161:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/partition_function.py:181:25: G004 Logging statement uses f-string tardis/plasma/properties/partition_function.py:192:21: G004 Logging statement uses f-string tardis/plasma/properties/partition_function.py:199:21: G004 Logging statement uses f-string tardis/plasma/properties/partition_function.py:252:21: RET506 Unnecessary `else` after `raise` statement tardis/plasma/properties/partition_function.py:395:21: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/plasma_input.py:2:5: F401 [*] `tardis.plasma.properties.base.ArrayInput` imported but unused tardis/plasma/properties/radiative_properties.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/properties/radiative_properties.py:42:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/radiative_properties.py:178:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/plasma/properties/rate_matrix_index.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/radiation_field/__init__.py:2:5: F401 `tardis.plasma.radiation_field.planck_rad_field.DilutePlanckianRadiationField` imported but unused; consider removing, adding to `__all__`, or using a redundant alias tardis/plasma/tests/test_complete_plasmas.py:149:27: FLY002 Consider `f"{hash_string}_{prop}"` instead of string join tardis/plasma/tests/test_complete_plasmas.py:154:39: FLY002 Consider `f"{hash_string}_{nlte_prop}"` instead of string join tardis/plasma/tests/test_hdf_plasma.py:1:17: F401 [*] `numpy` imported but unused tardis/plasma/tests/test_nlte_excitation.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/tests/test_nlte_excitation.py:5:27: F401 [*] `numpy.testing.assert_allclose` imported but unused tardis/plasma/tests/test_nlte_solver.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/plasma/tests/test_nlte_solver.py:5:25: F811 [*] Redefinition of unused `npt` from line 2 tardis/plasma/tests/test_plasma_continuum.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/simulation/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/simulation/base.py:155:14: UP008 Use `super()` instead of `super(__class__, self)` tardis/simulation/base.py:199:13: RET506 Unnecessary `else` after `raise` statement tardis/simulation/base.py:263:17: G004 Logging statement uses f-string tardis/simulation/base.py:270:9: RET505 Unnecessary `else` after `return` statement tardis/simulation/base.py:451:13: G004 Logging statement uses f-string tardis/simulation/base.py:549:13: G004 Logging statement uses f-string tardis/simulation/base.py:656:25: G004 Logging statement uses f-string tardis/simulation/base.py:659:13: G004 Logging statement uses f-string tardis/simulation/base.py:664:13: G004 Logging statement uses f-string tardis/simulation/base.py:715:13: TRY300 Consider moving this statement to an `else` block tardis/simulation/base.py:717:26: G004 Logging statement uses f-string tardis/visualization/tools/tests/test_rpacket_plot.py:3:1: I001 [*] Import block is un-sorted or un-formatted tardis/visualization/widgets/shell_info.py:1:1: I001 [*] Import block is un-sorted or un-formatted tardis/visualization/widgets/shell_info.py:1:25: F401 [*] `tardis.base.run_tardis` imported but unused tardis/visualization/widgets/shell_info.py:2:51: F401 [*] `tardis.io.atom_data.atom_web_download.download_atom_data` imported but unused tardis/visualization/widgets/shell_info.py:12:17: F401 [*] `numpy` imported but unused tardis/visualization/widgets/shell_info.py:299:25: PIE808 [*] Unnecessary `start` argument in `range` tardis_env3.yml:3:10: E999 SyntaxError: Expected an expression Found 275 errors. [*] 124 fixable with the `--fix` option (42 hidden fixes can be enabled with the `--unsafe-fixes` option). ```
atharva-2001 commented 2 months ago

This also needs to be removed from the relevant tests, correct?

Fixed in 624a225 (#2746)

tardis-bot commented 2 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (2aa673230898eaae8880bd951bb4e6aac9c9c62c) and the latest commit (0ec46084cb4f91f769e310e07dba1efbdeaea027). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff Benchmarks that have stayed the same: | Change | Before [81ec6e8e] | After [0ec46084] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------| | | 1.68±0ms | 2.17±0.2ms | ~1.29 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop | | | 6.07±0.9μs | 7.71±2μs | ~1.27 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket | | | 41.1±10μs | 45.8±20μs | ~1.12 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission | | | 2.50±0.4ms | 2.63±0.5ms | 1.05 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop | | | 30.4±0μs | 31.6±0.01μs | 1.04 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list | | | 60.6±0.08ms | 62.3±0.05ms | 1.03 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe | | | 3.32±0.6μs | 3.41±0.4μs | 1.03 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell | | | 531±200ns | 541±200ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation | | | 2.85±0.6μs | 2.90±0.7μs | 1.02 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket | | | 561±200ns | 561±100ns | 1.00 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation | | | 3.81±0ms | 3.81±0.04ms | 1.00 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') | | | 1.01±0m | 1.01±0m | 1.00 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking | | | 2.08±0m | 2.08±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions | | | 37.6±0.01s | 37.4±0s | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis | | | 206±0.08ns | 204±0.1ns | 0.99 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body | | | 1.19±0μs | 1.17±0μs | 0.98 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary | | | 717±0.2ns | 704±0.7ns | 0.98 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter | | | 21.0±5μs | 20.6±5μs | 0.98 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list | | | 1.98±0.9μs | 1.92±1μs | 0.97 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators | | | 2.79±0ms | 2.67±0.01ms | 0.96 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') | | | 44.2±20μs | 42.2±20μs | 0.96 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter | | | 592±100ns | 561±200ns | 0.95 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation | | | 7.59±1μs | 7.15±1μs | 0.94 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley | | | 1.43±0.4μs | 1.31±0.3μs | 0.92 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line | ```

If you want to see the graph of the results, you can check it here

atharva-2001 commented 2 months ago

Solving these errors will be easier once https://github.com/tardis-sn/tardis/pull/2808 is merged, I will address these once immediately once that is merged.

tardis-bot commented 1 month ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.