Inconsistent warning message logging

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

204 stars 406 forks source link

Inconsistent warning message logging #2755

Open DeerWhale opened 4 months ago

DeerWhale commented 4 months ago

Describe the bug logger.warn is deprecated, we should update all the warning message logging that uses logger to logger.warning Instead.

In addition, there are still several places in the TARDIS code base that use warnings package instead of logger to log the warning messages. This should be check as well to make it consistent.

atharva-2001 commented 4 months ago

Should we also be moving from warnings.warn to logger.warning?