search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
204 stars 406 forks source link

Donot run docs, benchmarks and stardis tests on draft PRs. #2761

Closed KasukabeDefenceForce closed 3 months ago

KasukabeDefenceForce commented 3 months ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

This PR makes sure that the build docs, benchmarks and stardis tests are run on a PR which is ready for review.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran ruff on the latest commit (4b63c66757bf87dc7c79c09f64724ad55c5a73b9). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff ```

Complete output(might be large):

```diff ```
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.30%. Comparing base (7231707) to head (4b63c66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2761 +/- ## ========================================== - Coverage 69.86% 69.30% -0.56% ========================================== Files 192 192 Lines 15048 15048 ========================================== - Hits 10513 10429 -84 - Misses 4535 4619 +84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KasukabeDefenceForce commented 3 months ago

Sample PR to test the changes: https://github.com/KasukabeDefenceForce/tardis/pull/39

Sample Run: https://github.com/KasukabeDefenceForce/tardis/pull/38

andrewfullard commented 3 months ago

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

KasukabeDefenceForce commented 3 months ago

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

andrewfullard commented 3 months ago

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

I can't mark the PR as ready for review on your fork but I do see the actions running.

KasukabeDefenceForce commented 3 months ago

Can we also trigger the actions when the PR changes from draft to ready? I think that is what @wkerzendorf wanted so that we don't forget the labels.

Yes I have shared a link to the PR on my fork. You can test it on that.

I can't mark the PR as ready for review on your fork but I do see the actions running.

Oh I forgot about that, apologies. Yes, it is setup in a way that the tests will start after we shift it to ready for review.