Closed wkerzendorf closed 2 weeks ago
*beep* *bop* Hi human, I ran ruff on the latest commit (71cc4564b5ed3d5031653ea894f6c3821156ae90). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
*beep* *bop*
Hi, human.
The docs
workflow has succeeded :heavy_check_mark:
Click here to see your results.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (3a391ae6aa0cb056b48c2febb23fa364323a5610) and the latest commit (71cc4564b5ed3d5031653ea894f6c3821156ae90). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
Tests rely on https://github.com/tardis-sn/tardis-regression-data/pull/24 merging first.
As far as I can tell it looks fine, but it's always hard to tell with the restructure PRs which parts are renames or functional changes worth paying attention to, or are just files and functions being moved around to places that make more sense.
In this case @jvshields I think the tests are most illustrative because we compare this new structure with the previous way(s) of doing things.
Tests are now failing for a different but related reason. electron_densities
seems to stick around in memory for too long. Unclear why.
Attention: Patch coverage is 84.37500%
with 40 lines
in your changes missing coverage. Please review.
Project coverage is 70.70%. Comparing base (
3a391ae
) to head (71cc456
). Report is 12 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB