search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

Add Extend Array Function #2771

Closed Sumit112192 closed 2 months ago

Sumit112192 commented 3 months ago

:pencil: Description

Type: :roller_coaster: restructure

Add an extend array function to RPacketTracker class

tardis-bot commented 3 months ago

*beep* *bop* Hi human, I ran ruff on the latest commit (0d6dcecc596948df7f8de44e395d73ab4f285f34). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff ```

Complete output(might be large):

```diff ```
Sumit112192 commented 3 months ago

@wkerzendorf @andrewfullard Aren't numpy arrays passed by reference by default?

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.32%. Comparing base (9339cd2) to head (0d6dcec). Report is 1 commits behind head on master.

Files Patch % Lines
tardis/transport/montecarlo/packet_trackers.py 7.69% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2771 +/- ## ========================================== - Coverage 69.81% 69.32% -0.50% ========================================== Files 196 196 Lines 15002 14999 -3 ========================================== - Hits 10474 10398 -76 - Misses 4528 4601 +73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sumit112192 commented 3 months ago

I should add a test for this function.

Sumit112192 commented 3 months ago

@andrewfullard @wkerzendorf This PR is now complete and ready to review.