Open Sumit112192 opened 1 month ago
I have to implement tests for this new functionality
*beep* *bop* Hi human, I ran ruff on the latest commit (3f7a9437cf05410c4d3a7138834638e38376ab58). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
@wkerzendorf @andrewfullard please review.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (30427ff00f444d30d74f7967a8ff8cb26c09ae7a) and the latest commit (ac8189dc1af9b1cb752bf7486cfd676f3c0cd90e). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
@andrewfullard Can you look at the segregation of line interaction as before line interaction and after line interaction in the track_line_interaction
function and suggest some changes or comments?
@andrewfullard Can you look at the segregation of line interaction as before line interaction and after line interaction in the
track_line_interaction
function and suggest some changes or comments?
Given that you need to detect the line interaction before and after the interaction process, I'm not sure what else can be done apart from essentially duplicating the method instead of having the if else
switch.
The reason rpacket_tracker
's boundary_interaction
tests are failing because both line_interactions and boundary_interactions have a common field event_id
more specifically the interaction number. Since, the line_interactions are added, the event_id
of boundary_interaction
s are changed. So, I have to update the regression data for the boundary_interaction
.
:pencil: Description
Type: :rocket:
feature
This PR builds up on PR #2736. Just like boundary interaction this PR introduces the line interaction data to the tracker.