Closed Sumit112192 closed 1 month ago
I have updated the docstring so that if someone works on the tracker classes, they should be able to modify it.
*beep* *bop* Hi human, I ran ruff on the latest commit (c66f452d56e443b22c1fc826395f8ee0ac1f22bf). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.42%. Comparing base (
e1aa887
) to head (c66f452
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (e1aa88723a6836e8a25cc1afb24b578b1b78651f) and the latest commit (c66f452d56e443b22c1fc826395f8ee0ac1f22bf). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
:pencil: Description
Type: :roller_coaster:
documentation
Earlier the docstring meant that the
shell_id
is of the last line interaction. For eg, if interaction_type is [Line, Escatter, Escatter, Line, Escatter] and the shell_id is [0, 1, 2, 2, 3, 4]. So the docstring sounded like it should return 3 since the last line interaction happened in the 3rd shell, but that was not the case.The fixtures return the shell_id when the last interaction is strictly line For eg, if interaction_type is [Line, Escatter, Escatter, Line, Escatter] and the shell_id is [0, 1, 2, 2, 3, 4]. In this case, since the last interaction is Escatter, it should not return anything.