Closed sarthak-dv closed 2 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
*beep* *bop* Hi human, I ran ruff on the latest commit (c4b9ff891cc5ea09fe1a6201bf90505e5881408c). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
Attention: Patch coverage is 0%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 69.37%. Comparing base (
92df2cf
) to head (c4b9ff8
).
Files | Patch % | Lines |
---|---|---|
tardis/visualization/tools/liv_plot.py | 0.00% | 16 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop*
Hi, human.
The docs
workflow has succeeded :heavy_check_mark:
Click here to see your results.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (92df2cf4777498eb3ac90156843e806df6cb7118) and the latest commit (c4b9ff891cc5ea09fe1a6201bf90505e5881408c). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
@jamesgillanders @jaladh-singhal I have added the species not found in wvl range logger, please review this PR.
Looks good to me - some minor comments for notebook
Thanks for noticing the errors I missed, I have made the corrections please review it again.
:pencil: Description
Type: :rocket:
feature
Added a Wavelength range filter to restrict the analysis of interacting packets in LIV Plot.
:pushpin: Resources
Examples, notebooks, and links to useful references.
:vertical_traffic_light: Testing
How did you test these changes?
:ballot_box_with_check: Checklist
build_docs
label