Open andrewfullard opened 2 months ago
*beep* *bop* Hi human, I ran ruff on the latest commit (9b7263dfa59ceff9f2418d4f7d8745dca012192d). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.55%. Comparing base (
4341331
) to head (9b7263d
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (434133196adc18ca360c71779204bee9d37cd6c5) and the latest commit (9b7263dfa59ceff9f2418d4f7d8745dca012192d). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
Need add tests, converting to draft for now.
Has basically the same interface as ConvergenceSolver
:pencil: Description
Type: :rocket:
feature
Radiative temperature and dilution factor have been unified in many parts of the code as a radiation field object. This PR creates a convergence class to handle them as one item, with the option to check convergence for them both simultaneously (currently defaults to off and is not settable).
:vertical_traffic_light: Testing
How did you test these changes?
:ballot_box_with_check: Checklist
build_docs
label