Open Sumit112192 opened 1 month ago
*beep* *bop* Hi human, I ran ruff on the latest commit (85787999dfd611d0d5f6799ffa02b93ef8b6e6e3). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 70.78%. Comparing base (
5fe6806
) to head (8578799
). Report is 6 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
tardis/transport/montecarlo/packet_trackers.py | 33.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (5fe6806d2dc18afa155ffeb3a3cb31518637a214) and the latest commit (85787999dfd611d0d5f6799ffa02b93ef8b6e6e3). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
What exactly do you mean by "emitted"? Escaped the outer boundary of the simulation?
What exactly do you mean by "emitted"? Escaped the outer boundary of the simulation?
class PacketStatus(IntEnum):
IN_PROCESS = 0
EMITTED = 1
REABSORBED = 2
ADIABATIC_COOLING = 4
Yes. In the end, the packet is emitted from the ejecta or reabsorbed in the photosphere.
:pencil: Description
Type: :rocket:
feature
This PR adds a
status
property to the RPacketLastInteractionTracker as it can be used to determine whether the packet was reabsorbed or emitted.