Closed jvshields closed 2 months ago
*beep* *bop* Hi human, I ran ruff on the latest commit (ec4d62ad7b17332ad72001f315e642ade5bfd9ec). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:
Complete output(might be large):
Seems reasonable. Should definitely become a class eventually.
Attention: Patch coverage is 70.00000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 70.79%. Comparing base (
5fe6806
) to head (ec4d62a
). Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
tardis/io/atom_data/base.py | 70.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (5fe6806d2dc18afa155ffeb3a3cb31518637a214) and the latest commit (ec4d62ad7b17332ad72001f315e642ade5bfd9ec). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.
Significantly changed benchmarks:
All benchmarks:
If you want to see the graph of the results, you can check it here
Seems reasonable. Should definitely become a class eventually.
I think make it a dataclass now to put all of these together in one.
Needed for STARDIS to access the molecular information ingested by carsus added in https://github.com/tardis-sn/carsus/pull/396
Currently I don't think it's worth adding a molecular_data class, but if we ever want to do more complex handling of molecules, calculating them in a similar way to atomic number densities instead of just using equilibrium constants, then it might be worth reconsidering.