TARDISData dataclass to hold data about atoms

andrewfullard commented 2 weeks ago

:pencil: Description

Type: :rocket: feature

This class will store the unfiltered data about atoms, ions et al. for the TARDIS plasma and transport. Name suggestions welcome.

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 2 weeks ago

*beep* *bop* Hi human, I ran ruff on the latest commit (447b71b59089976041958608e345fbf17540ad3c). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 3 G004 [ ] Logging statement uses f-string 1 FA102 [*] Missing `from __future__ import annotations`, but uses PEP 604 union 1 G001 [ ] Logging statement uses `str.format` 1 E902 [ ] No such file or directory (os error 2) 1 UP030 [*] Use implicit references for positional format fields ```

Complete output(might be large):

```diff .github/workflows/codespell.yml:1:1: E902 No such file or directory (os error 2) tardis/io/atom_data/base.py:199:34: G004 Logging statement uses f-string tardis/io/atom_data/base.py:264:17: G004 Logging statement uses f-string tardis/io/atom_data/base.py:268:21: UP030 Use implicit references for positional format fields tardis/io/atom_data/base.py:268:21: G001 Logging statement uses `str.format` tardis/io/atom_data/base.py:734:17: G004 Logging statement uses f-string tardis/plasma/assembly/base.py:132:22: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union Found 7 errors. No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option). ```

wkerzendorf commented 2 weeks ago

So the TARDIS Data class is now mirroring atomic data, correct? I would put it in the a new tardis_data.py package then.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.67%. Comparing base (b79b61e) to head (dc4c9d3).

Files	Patch %	Lines
tardis/io/atom_data/tardis_data.py	0.00%	27 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2812 +/- ## ========================================== - Coverage 70.96% 70.67% -0.30% ========================================== Files 209 210 +1 Lines 15638 15665 +27 ========================================== - Hits 11098 11071 -27 - Misses 4540 4594 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-sn / tardis