Handling for qgridnext installation

andrewfullard commented 2 months ago

:pencil: Description

Type: :memo: documentation

Adds a try-except block to catch the ModuleNotFoundError and notify the user via logs. Also adds a note to docs. Output from logs:

:vertical_traffic_light: Testing

How did you test these changes?

[x] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[x] I requested two reviewers for this pull request
[x] I updated the documentation according to my changes
[x] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tardis-bot commented 2 months ago

*beep* *bop* Hi human, I ran ruff on the latest commit (e1a60c127588de2c86ef8a291e46fcadf3a56593). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 1 I001 [*] Import block is un-sorted or un-formatted 1 F401 [*] `tardis.visualization.shell_info_from_hdf` imported but unused ```

Complete output(might be large):

```diff docs/io/visualization/how_to_generating_widgets.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted docs/io/visualization/how_to_generating_widgets.ipynb:cell 5:3:5: F401 [*] `tardis.visualization.shell_info_from_hdf` imported but unused Found 2 errors. [*] 2 fixable with the `--fix` option. ```

tardis-bot commented 2 months ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

tardis-bot commented 2 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (260207cb7cee6829390d77fbf48de53843818f09) and the latest commit (e1a60c127588de2c86ef8a291e46fcadf3a56593). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff Benchmarks that have stayed the same: | Change | Before [260207cb] | After [e1a60c12] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------| | | 6.77±2μs | 8.21±2μs | ~1.21 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley | | | 2.61±0.4ms | 3.07±0.6ms | ~1.18 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop | | | 4.32±0.06ms | 3.92±0ms | ~0.91 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') | | | 2.09±0.02ms | 1.81±0.03ms | ~0.87 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop | | | 2.37±2μs | 2.05±1μs | ~0.86 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators | | | 3.43±0.3μs | 2.93±0.5μs | ~0.86 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket | | | 7.32±1μs | 5.70±1μs | ~0.78 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket | | | 1.83±0.5μs | 1.32±0.4μs | ~0.72 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line | | | 34.0±10μs | 20.5±5μs | ~0.60 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list | | | 3.52±0.3μs | 3.80±0.6μs | 1.08 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell | | | 541±100ns | 581±100ns | 1.07 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation | | | 43.2±20μs | 45.1±30μs | 1.04 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission | | | 561±100ns | 571±200ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation | | | 203±0.05ns | 207±0.2ns | 1.02 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body | | | 30.5±0.01μs | 31.0±0.1μs | 1.02 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list | | | 1.20±0μs | 1.21±0μs | 1.01 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary | | | 530±100ns | 532±200ns | 1.00 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation | | | 39.6±0.1s | 39.7±0s | 1.00 | run_tardis.BenchmarkRunTardis.time_run_tardis | | | 44.7±30μs | 44.8±30μs | 1.00 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter | | | 736±0.4ns | 734±0.6ns | 1.00 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter | | | 1.07±0.01m | 1.06±0m | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking | | | 2.09±0m | 2.07±0m | 0.99 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions | | | 3.19±0.03ms | 3.05±0.03ms | 0.96 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') | | | 67.0±0.2ms | 64.6±0.06ms | 0.96 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe | ```

If you want to see the graph of the results, you can check it here

andrewfullard commented 2 months ago

Test failures are waiting on #2808 and #2811 to be merged

tardis-sn / tardis