search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
204 stars 406 forks source link

Failing benchmarks fix #2831

Closed atharva-2001 closed 1 month ago

atharva-2001 commented 1 month ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

Benchmarks fail- https://github.com/tardis-sn/tardis/actions/runs/11105960403/job/30853255761?pr=2830

asv made a new release recently which requires conda-build if you use mamba to setup dependencies- https://github.com/airspeed-velocity/asv/releases/tag/v0.6.4

Benchmarks run- https://github.com/tardis-sn/tardis/actions/runs/11107154026/job/30857095092?pr=2831

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 1 month ago

*beep* *bop* Hi human, I ran ruff on the latest commit (929b2d2f886c21bb766ee3795f70127fd7a8f0e3). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 7 W291 [*] Trailing whitespace 2 W293 [*] Blank line contains whitespace 1 E999 [ ] SyntaxError: Expected an expression ```

Complete output(might be large):

```diff .github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression .github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:81:49: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:111:81: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:112:54: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:199:1: W293 [*] Blank line contains whitespace .github/workflows/benchmarks.yml:218:22: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:219:170: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:221:84: W291 [*] Trailing whitespace .github/workflows/benchmarks.yml:238:1: W293 [*] Blank line contains whitespace Found 10 errors. [*] 9 fixable with the `--fix` option. ```
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.72%. Comparing base (de4d872) to head (929b2d2). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2831 +/- ## ========================================== - Coverage 70.89% 70.72% -0.18% ========================================== Files 209 209 Lines 15589 15589 ========================================== - Hits 11052 11025 -27 - Misses 4537 4564 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.