Fixes qgridnext import error in tests

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

204 stars 406 forks source link

Fixes qgridnext import error in tests #2834

Closed andrewfullard closed 1 month ago

andrewfullard commented 1 month ago

:pencil: Description

Type: :beetle: bugfix

The previous qgridnext import check #2819 caused tests to fail. This version falls back to regular qgrid, which will still raise an exception logging error but prevents test failures.

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 1 month ago

*beep* *bop* Hi human, I ran ruff on the latest commit (d75e7783310df083cb4ea3041c19f835dd4eb561). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff ```

Complete output(might be large):

```diff All checks passed! ```

tardis-bot commented 1 month ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (4c6780c) to head (d75e778). Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
tardis/visualization/widgets/util.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2834 +/- ## ========================================== - Coverage 70.87% 70.51% -0.37% ========================================== Files 209 209 Lines 15589 15589 ========================================== - Hits 11049 10992 -57 - Misses 4540 4597 +57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.