Remove integration tests

KasukabeDefenceForce commented 1 month ago

:pencil: Description

This PR removes the outdated integration tests.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 1 month ago

*beep* *bop* Hi human, I ran ruff on the latest commit (f010b75286259cafd91a4dae0f6ae3ec1300102e). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 15 E902 No such file or directory (os error 2) ```

Complete output(might be large):

```diff tardis/tests/integration_tests/__init__.py:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/at/abundances.dat:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/at/config.yml:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/at/densities.dat:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/conftest.py:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/paper1_downbranch/config.yml:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/paper1_macroatom/abundances.dat:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/paper1_macroatom/config.yml:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/paper1_macroatom/densities.dat:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/paper1_scatter/config.yml:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/runner.py:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/test_integration.py:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/w7/abundances.dat:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/w7/config.yml:1:1: E902 No such file or directory (os error 2) tardis/tests/integration_tests/w7/densities.dat:1:1: E902 No such file or directory (os error 2) Found 15 errors. ```

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.87%. Comparing base (5f11626) to head (f010b75). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2844 +/- ## ========================================== - Coverage 69.97% 69.87% -0.11% ========================================== Files 216 214 -2 Lines 16077 15981 -96 ========================================== - Hits 11250 11166 -84 + Misses 4827 4815 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-bot commented 1 month ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (5f11626350bc1a87eee0f8ed9b5adf7812a7c8f6) and the latest commit (f010b75286259cafd91a4dae0f6ae3ec1300102e). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff Benchmarks that have stayed the same: | Change | Before [5f116263] | After [f010b752] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------| | | 3.02±0.4μs | 3.61±0.4μs | ~1.20 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell | | | 571±200ns | 641±100ns | ~1.12 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation | | | 19.0±4μs | 21.4±5μs | ~1.12 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list | | | 2.70±0.6μs | 2.99±0.4μs | ~1.11 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket | | | 5.80±0.8μs | 6.46±0.6μs | ~1.11 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket | | | 46.2±20μs | 41.8±20μs | ~0.90 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission | | | 1.57±0.3μs | 1.40±0.4μs | ~0.89 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line | | | 45.8±20μs | 49.1±30μs | 1.07 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter | | | 3.44±0.01ms | 3.65±0ms | 1.06 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') | | | 734±0.5ns | 774±0.4ns | 1.05 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter | | | 204±0.2ns | 210±0.4ns | 1.03 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body | | | 541±100ns | 550±100ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation | | | 2.71±0ms | 2.76±0.01ms | 1.02 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') | | | 2.08±1μs | 2.11±1μs | 1.02 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators | | | 30.6±0.04μs | 30.9±0.02μs | 1.01 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list | | | 541±200ns | 541±100ns | 1.00 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation | | | 2.07±0m | 2.06±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions | | | 1.20±0μs | 1.20±0μs | 1.00 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary | | | 40.2±0.04s | 39.9±0.05s | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis | | | 1.06±0m | 1.05±0m | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking | | | 1.67±0.01ms | 1.66±0.01ms | 0.99 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop | | | 2.58±0.4ms | 2.55±0.4ms | 0.99 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop | | | 7.30±2μs | 7.24±2μs | 0.99 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley | | | 64.5±0.2ms | 63.4±0.01ms | 0.98 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe | ```

If you want to see the graph of the results, you can check it here

andrewfullard commented 1 month ago

Can you check that the configuration yml files are stored in https://github.com/tardis-sn/tardis-setups ?

KasukabeDefenceForce commented 1 month ago

Can you check that the configuration yml files are stored in https://github.com/tardis-sn/tardis-setups ?

I dont think its there. Should I create a new dir and copy only the config files in that repo?

andrewfullard commented 1 month ago

Can you check that the configuration yml files are stored in https://github.com/tardis-sn/tardis-setups ?

I dont think its there. Should I create a new dir and copy only the config files in that repo?

Yes, make sure these configurations are stored there in some form.

KasukabeDefenceForce commented 1 month ago

Can you check that the configuration yml files are stored in https://github.com/tardis-sn/tardis-setups ?

I dont think its there. Should I create a new dir and copy only the config files in that repo?

Yes, make sure these configurations are stored there in some form.

https://github.com/tardis-sn/tardis-setups/pull/22

tardis-sn / tardis