tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
204 stars 406 forks source link

Fix build docs workflow #2885

Open KasukabeDefenceForce opened 1 week ago

KasukabeDefenceForce commented 1 week ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

The build docs workflow is skipping when there are changes in docs and a label is applied.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 1 week ago

*beep* *bop* Hi human, I ran ruff on the latest commit (83a17576647e85b68ea4986d894283e6292f6b5e). Here are the outputs produced. Results can also be downloaded as artifacts here. Summarised output:

```diff 1 E999 SyntaxError: Expected an expression ```

Complete output(might be large):

```diff .github/workflows/build-docs.yml:7:4: E999 SyntaxError: Expected an expression Found 1 error. ```
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.87%. Comparing base (83282e3) to head (83a1757).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2885 +/- ## ========================================== - Coverage 70.22% 69.87% -0.36% ========================================== Files 214 214 Lines 15981 15981 ========================================== - Hits 11223 11166 -57 - Misses 4758 4815 +57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-bot commented 1 week ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (83282e3c5061cbb6a0f7ffbbece2fb534e4f5dc6) and the latest commit (83a17576647e85b68ea4986d894283e6292f6b5e). Here are the logs produced by ASV. Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff Benchmarks that have stayed the same: | Change | Before [83282e3c] | After [83a17576] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------| | | 23.1±6μs | 31.7±10μs | ~1.37 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list | | | 3.42±0.4μs | 4.38±0.6μs | ~1.28 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell | | | 2.13±1μs | 2.47±1μs | ~1.16 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators | | | 521±200ns | 591±200ns | ~1.13 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation | | | 3.16±0.6μs | 2.81±0.7μs | ~0.89 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket | | | 582±100ns | 511±200ns | ~0.88 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation | | | 4.38±0.06ms | 3.71±0.04ms | ~0.85 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') | | | 7.14±2μs | 7.71±2μs | 1.08 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley | | | 1.17±0μs | 1.19±0μs | 1.02 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary | | | 2.08±0m | 2.09±0m | 1.01 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions | | | 561±200ns | 561±200ns | 1.00 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation | | | 48.4±30μs | 48.3±40μs | 1.00 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter | | | 1.07±0m | 1.06±0m | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking | | | 204±0.4ns | 202±0.09ns | 0.99 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body | | | 31.3±0.01μs | 31.0±0.04μs | 0.99 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list | | | 65.4±0.05ms | 64.6±0.07ms | 0.99 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe | | | 41.2±0.05s | 40.2±0.1s | 0.98 | run_tardis.BenchmarkRunTardis.time_run_tardis | | | 740±0.5ns | 726±0.4ns | 0.98 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter | | | 1.78±0ms | 1.75±0.03ms | 0.98 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop | | | 2.68±0.4ms | 2.63±0.5ms | 0.98 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop | | | 43.7±30μs | 42.1±30μs | 0.96 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission | | | 6.52±0.8μs | 6.25±0.5μs | 0.96 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket | | | 1.55±0.4μs | 1.45±0.4μs | 0.94 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line | | | 3.73±0ms | 3.41±0.05ms | 0.91 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') | ```

If you want to see the graph of the results, you can check it here