search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
199 stars 404 forks source link

NLTE not working #777

Closed livnehra closed 6 years ago

livnehra commented 7 years ago

Hi,

NLTE is not working for me in tardis version 1.5.dev2783. This occurs for different species and gives at least 2 types of errors. My setup is standard, using the given kurucz atomic dataset. Enclosed find Yaml files and results.

pip_list.txt tardis_example_nlte.zip

yeganer commented 7 years ago

Thanks for the config. So far I found several issues with the current state of the code and I'll work on solving these in the course of next week. Please stay tuned :)

yeganer commented 7 years ago

@livnehra I looked into the issues and #778 should fix NLTE for now. setup2 runs fine but setup1 has a different error which most likely is related to me not using a database that contains collision data.

livnehra commented 7 years ago

OK, great! I'll wait for the merge, rebase and check.

yeganer commented 7 years ago

It looks like NLTE is working again. I was able to reproduce figure 10 of KerzendorfSim2014:

nlte_verification

unoebauer commented 6 years ago

According to @yeganer, this issue has been fixed by #778. Closing this one.

livnehra commented 6 years ago

Hi,

NLTE is not working again... It worked well when I was on version dev2869, except the atomic database was bad for some elements. Now I rebased to dev3025, and NLTE doesn't work at all. I'm using the same sample files posted above, with kurucz_cd23_chianti_H_He.h5 from tardis-refdata/atom_data/.

The result: result.txt

Hope I'm not doing something silly... pip_list_new.txt

Thanks!

yeganer commented 6 years ago

@livnehra Which setup caused this error? Setup 1 or Setup 2?

yeganer commented 6 years ago

I think you have to use the other atomic database: kurucz_atom_chianti_many.h5. If I read the error correctly, it is looking for collisional data which the default database does not contain. kurucz_atom_chianti_many.h5 contains these data for S, Si, Ca and Mg.

livnehra commented 6 years ago

OK, So with kurucz_atom_chianti_many.h5 Si II works but S II and Ca II give the same KeyError. Before the latest updates (~2 months) S and Ca did work...

yeganer commented 6 years ago

I checked, kurucz_atom_chianti_many.h5 only contains ions for Silicon. I'll have a look what went wrong because I'm confident it worked one month ago during GSoC.

yeganer commented 6 years ago

@livnehra I tracked down the problem to a bug in the exporting from carsus and I will look into a fix. Afterwards the atomic database has to be regenerated which takes several hours. You can expect an update tomorrow or maybe even late this evening (CET).

livnehra commented 6 years ago

Hi, Any news regarding this issue? I'm really looking forward to doing some more Tardis runs :) Thanks!!

wkerzendorf commented 6 years ago

@livnehra I'm sure you want to explore the kilonova ;-) @yeganer can you tell me what needs to be fixed or what is fixed. Thank you very much

wkerzendorf commented 6 years ago

@livnehra it should be fixed with the new atomic data that @yeganer just pushed

@yeganer thank you very much for doing this!!!

livnehra commented 6 years ago

Many thanks !! Will check ASAP