search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
199 stars 404 forks source link

Unable to use nlte for some species in 1.5.dev3036 #808

Closed Heringer-Epson closed 4 years ago

Heringer-Epson commented 6 years ago

Hi all,

I'm able to use the nlte option for He, but not for any other element. Any thoughts of what can be going wrong? Perhaps I'm not using the appropriate atomic data? (currently using https://github.com/yeganer/tardis-refdata/blob/carsus_update/atom_data/kurucz_cd23_chianti_H_He.h5).

yml files I'm using can be found at the links below: He test (works): http://128.100.88.57/lib/exe/fetch.php?media=2018_-_jan:nlte_he.yml Si test (does not work - error msg below): http://128.100.88.57/lib/exe/fetch.php?media=2018_-_jan:nlte_si.yml

Any suggestions are greatly appreciated =) Epson

File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/base.py", line 37, in run_tardis simulation = Simulation.from_config(tardis_config, atom_data=atom_data) File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/simulation/base.py", line 353, in from_config atom_data=kwargs.get('atom_data', None)) File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/plasma/standard_plasmas.py", line 88, in assemble_plasma nlte_species=nlte_species) File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/io/atomic.py", line 379, in prepare_atom_data self.nlte_data = NLTEData(self, nlte_species) File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/io/atomic.py", line 396, in init self._create_collision_coefficient_matrix() File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/tardis_sn-1.5.dev3036-py2.7-linux-x86_64.egg/tardis/io/atomic.py", line 440, in _create_collision_coefficient_matrix collision_group.get_group(species).iterrows()): File "/home/heringer/anaconda2/envs/tardis/lib/python2.7/site-packages/pandas/core/groupby.py", line 587, in get_group raise KeyError(name) KeyError: (14, 1)

wkerzendorf commented 6 years ago

This atom data only works for H, He NLTE (which has some other drawbacks). You need a different atomic dataset. the chianti_many at https://github.com/tardis-sn/tardis-refdata/tree/master/atom_data should work

Heringer-Epson commented 6 years ago

I see, using the chianti_many database does work for Si and Ca, but I still get the same error for C. Anything I can do about it?

slietzau commented 6 years ago

I believe chianti_many database only contains the elements for the original TARDIS paper, if you need specific elements I think one has to generate a new database. But it could be that such a database already exists. If you want I can check later.

unoebauer commented 6 years ago

What's the status of this problem, @Heringer-Epson, @wkerzendorf?

wkerzendorf commented 4 years ago

@chvogl will implement van Regemorter Approximation anyways.