tardyp / sphinx-jinja

MIT License
28 stars 22 forks source link

docutils dependency? #28

Closed av8r closed 2 years ago

av8r commented 2 years ago

Hi

Any reason to pin docutils too 0.17.1 ? Installing sphinx-jinja results in downgrading sphinxdoc.

return42 commented 2 years ago

Hi @tardyp, are there any reasons to tag docutils at 0.16?

https://github.com/tardyp/sphinx-jinja/blob/c52bc7b88e68fd078605f3b9a3997bd2ded92cc0/pyproject.toml#L19

Take in mind ^ will only do updates that do not change the leftmost non-zero number (and this is 16)

Current Sphinx-doc supports docutils v0.17 and myst-parster requires v0.17. In our SearXNG project we need to use both and tagging v0.16 is a show stopper for us.

The conflict is caused by:
    The user requested docutils>=0.17
    sphinx 4.4.0 depends on docutils<0.18 and >=0.14
    sphinx-jinja 1.4.0 depends on docutils<0.17 and >=0.16
tardyp commented 2 years ago

No particular reason that I remember. I'll gladly merge a PR that upgrades this dep

Le lun. 7 mars 2022, 14:43, Markus Heiser @.***> a écrit :

Hi @tardyp https://github.com/tardyp, are there any reasons to tag docutils at 0.16?

https://github.com/tardyp/sphinx-jinja/blob/c52bc7b88e68fd078605f3b9a3997bd2ded92cc0/pyproject.toml#L19

Take in mind ^ will only do updates that do not change the leftmost non-zero number (and this is 16)

Current Sphinx-doc supports docutils v0.17 and myst-parster https://myst-parser.readthedocs.io/en/latest/sphinx/use.html#include-markdown-files-into-an-rst-file requires v0.17. In our SearXNG https://github.com/searxng/searxng project we need to use both and tagging v0.16 is a show stopper for us.

The conflict is caused by: The user requested docutils>=0.17 sphinx 4.4.0 depends on docutils<0.18 and >=0.14 sphinx-jinja 1.4.0 depends on docutils<0.17 and >=0.16

— Reply to this email directly, view it on GitHub https://github.com/tardyp/sphinx-jinja/issues/28#issuecomment-1060701874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA22I6A3UJ6M7BQLNVOBFDU6YBYFANCNFSM5MPPZKSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

return42 commented 2 years ago

No particular reason that I remember. I'll gladly merge a PR that upgrades this dep

I send https://github.com/tardyp/sphinx-jinja/pull/30

return42 commented 2 years ago

Thanks!

tardyp commented 2 years ago

well, actually, your PR did not update the poetry.lock. I updated it and now the tests do not pass.

Not sure when I can find some time for debugging this.. I would appreciate some help in this debug.