tardyp / sphinx-jinja

MIT License
28 stars 22 forks source link

bump version #31

Closed tardyp closed 2 years ago

return42 commented 2 years ago

TBH I do not know anything about poetry, but it seems the install command does not (fully) install? .. Here is what I have done to get the tests working ...

# checkout branch bumpversion and create a virtualenv
$ python3 -m venv  local
$ . ./local/bin/activate
(local) $ pip install poetry
(local) $ rm poetry.lock
(local) $ poetry install
(local) $ poetry run pytest

.. and the test fails (like shown in the CI) .. then I checked the installations in local/lib/python3.8/site-packages/sphinxcontrib but I missed the jinja.py file.

To install the sphinxcontrib.jinja I just run a pip install in the virtualenv:

(local) $ pip install .
(local) $ poetry run pytest
========================== test session starts ==========================
platform linux -- Python 3.8.10, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /800GBPCIex4/share/sphinx-jinja
collected 7 items                                                       

tests/test_basic.py .......                                       [100%]

=========================== 7 passed in 2.03s ===========================

.. and the tests are passed .. that is why I assume there has something changed with the poetry install command / FYI: in the virtualenv I have installed ..

(local) $ poetry -V
Poetry version 1.1.13
return42 commented 2 years ago

that is why I assume there has something changed with the poetry install command

OK I found the issue and fixed it in https://github.com/tardyp/sphinx-jinja/pull/32

return42 commented 2 years ago

~Can you deploy a new release on Pypi?~

EDIT: I just missed the tag