tardypad / sailfishos-daily-comics

Daily comic strips reader for SailfishOS
MIT License
12 stars 17 forks source link

Inconsistencies when a comic fails / ways of contact #38

Closed Olf0 closed 5 years ago

Olf0 commented 6 years ago

Unfortunately "Wizard of ID" ceased to work 2018-04-05. Its website is working (http://www.creators.com/features/wizard-of-id) and displaying the strips from 2018-04-05 and 2018-04-06, which Daily Comics fails to display. The URL used for "Wizard of ID" by Daily Comics is also seems to be working (http://www.gocomics.com/wizardofid), but apparently something was changed there.

Daily Comics' behaviour is interesting though:

  1. When starting Daily Comics, it detects a new "Wizard of ID" strip and displays "⬇ New" for it.
  2. When entering "Wizard of ID" via "Read all new comics", a fully black screen (except for the back button in the upper left corner) is displayed: screenshot_20180406_003
  3. When entering "Wizard of ID" via its icon, an error message is displayed: screenshot_20180406_002
  4. After step 3, Daily Comics also displays "❗ Error" on the "Wizard of ID" icon, but returns to displaying "⬇ New" after a while, again (apparently the subscribed comics are rescanned).

Before 2018-04-05 I occasionally experienced "❗ Error" on some subscribed comics when trying to fetch (i.e. download) them, but never when trying to view them!

Expected results:

Side note: As Jolla's Mail was not configured and used before on this device (using K9 instead), trying to report via email results in screenshot_20180406_001 But I have no idea how to handle this better (Mimer unfortunately does not allow to set the default email application). Maybe an additional way to copy the generated error report including the email address and subject line to the clipboard (as an alternative to calling the email app with these parameters) is feasible.

Tested with Daily Comics 1.7.5-1 under SailfishOS 2.1.4.14 on a Jolla 1 phone.

sthocs commented 6 years ago

Hi, indeed GoComics has changed its website. I've fixed it and submitted a pull request here: #39 Until it's merged and put on OpenRepos, I've built a version with the fix that you can download here: http://sthocs.free.fr/harbour-dailycomics-1.7.5-2.armv7hl.rpm

Olf0 commented 6 years ago

@sthocs, thanks a lot for fixing the original issue: GoComics has changed their site layout. Side note: Kudos for compiling Daily Comics RPM v1.7.5-2, but unfortunately https://sthocs.free.fr/ (via HTTPS) permanently runs into connection timeouts for me (in Firefox and curl), but http://sthocs.free.fr/harbour-dailycomics-1.7.5-2.armv7hl.rpm works.

As your PR #39 addresses solely the original issue, IMO this issue report (#38) should be kept open after merging your PR, until the other bugs are investigated, which have been uncovered by GoComics change:

  1. Daily Comics should behave identically in steps 2 and 3, displaying an error message (as in step 3).
  2. A comic strip should either show "❗ Error" when failing to fetch its image file (e.g. by testing that an image file type has been successfully received), or (when successful) display the actual comic strip. But not state "⬇ New" (which is untrue, as no image file has been successfully fetched) and just display a fully black frame. Additionally Go Comics 1.7.5-1 behaves as if there is a permanently unread comic strip in this situation, as viewing the black frame does not seem to toggle the "read" flag (which may be resolved in one go by enhancing the error handling).
  3. Daily Comics should make the email address for bug reports also available by other means (e.g. in an "About"-page, which currently does not exist) than the aforementioned "contact me, if the problem persists"-button and the corresponding "Let me know ..."-button in its settings, as these fail, when Jolla's email client app is not configured (e.g. when using K9-Mail instead).
tardypad commented 6 years ago

Wizard of ID fix is now merged from the PR mentioned before.

I'll try to tackle the other issues for the next release if possible

As for 4, there is an about page at the bottom of the comics list, in a PushUp menu, with all the ways to contact me

Olf0 commented 6 years ago

@tardypad, thank you.

As for 4, I cannot find it, just the mentioned "Let me know ..."-button in its settings, which (also) depends on the Jolla Mail client to be configured: screenshot_20180512_001

Side note: A link to Daily Comics Github issue tracker (https://github.com/tardypad/sailfishos-daily-comics/issues/) IMO would be nice and cause your inbox to be loaded less.

tardypad commented 6 years ago

@Olf0 The About page is at the bottom of the main page, not of the settings page as you show

Olf0 commented 5 years ago

WRT sub-issue 4: @tardypad, thanks, I missed that bottom push-up menu at Daily Comics main page. Testing it reveals a couple of similar issues, there:

Hence no way of contact works for me.

IMO and due to @maledictus seemingly having taken over the maintenance of Daily Comics, this should be generalised by simply providing a few web-links to relevant locations. Thus filing this as sub-issue 5.

Sure, I concur that this bottom menu at Daily Comics' main page is the right place to display, e.g. (as possible solutions of sub-issue 5):

Also sub-issue 4 can be resolved the same way: By a link to Daily Comics' issue tracker (while its text and location at the bottom of the settings page is perfect and should be retained).

Maledictus commented 5 years ago

I have got write permissions to this repository and I can continue development of this project but I haven't access to openrepos account and @tardypad said that he will publish releases himself

Olf0 commented 5 years ago

@maledictus, I already gathered this from TJC and saw you committing here: Thank you very much! It is nice to have the chance to express that properly (in addition to a +1 at TJC), but OTOH this is not really related to this issue.

But while at this topic: You may still make releases and upload packaged RPMs at https://github.com/tardypad/sailfishos-daily-comics/releases (i.e., without @tardypad's help).

tardypad commented 5 years ago

I'm closing this issue which had become a list of different unrelated problems and requests. AFAICS the only problem left here is related to the handling of errors for which I just created a distinct issue (linking it to here if as a reference)

Olf0 commented 5 years ago

@tardypad, thanks. I absolutely agree, that this issue has been overloaded (mostly by me) with a bunch of issues, which are related in terms of user's workflow, but are technically unrelated.