added vidadeprogramador

tardypad / sailfishos-daily-comics

Daily comic strips reader for SailfishOS

MIT License

12 stars 17 forks source link

added vidadeprogramador #86

Closed caio2k closed 4 years ago

caio2k commented 5 years ago

Hello there, Thanks for your great job creating this app. I've read the guideline to add a comic and I'm adding 2 local brazilian comics into your app but as I don't have yet the environment ready to compile I cannot test the build. Please evaluate if I need it tested before creating a PR. Regards.

tardypad commented 5 years ago

Thanks for the PR

A few comments besides the ones in the review:

please also provide a 1000x1000 pixels cover.big.jpg just like the other ones have
if you can, split the commit to have each comic added in its own. Ideally they would be in 2 separate PR too to make it easier to review and merge.
in the cover of "videdesuporte", display a single character without any object around it.

caio2k commented 5 years ago

hey @tardypad i've updated the PR as you suggested. please take a look. whenever you accept it I will push the other PR with the next comics.

tardypad commented 5 years ago

Thanks for the changes, it looks fine now. However there is one more small item to fix because I forgot to press submit to the review previously... You can already open the other PR so I can look at them.

Olf0 commented 4 years ago

This is ready to be merged for 9 months, isn't it?

caio2k commented 4 years ago

Yes, it is there for a while. I could not open a new PR because there is one file that cannot be forked properly...

Maledictus commented 4 years ago

Thank you for your efforts