Closed ttodua closed 2 years ago
I think a better way to handle this would be with a filter allowing you to override the home URL and query param. I would like to avoid bloating the admin with settings as much as possible.
Is it possible to have an 'advanced' button (or 'expand' or whatever), and clicking after that these settings were visible? the point of plugin/extension is to offer wordpress users ability to avoid 'using codes' and hiring programmer to hardcode something, so, things were manageable from dashboard. at least, I am way much opponent of hardcoding things (as it's regress) and more advocate of providing users with capability to customize things as they want, and not to forbid. (actually, for me it's obvious that 'wordpress philosophy' which is in official wp chapter, is inherently broken, and not bright minded direction). The reason I've made a PR was because of the need for the project I worked on. however, as you wish. I will go with my fork. Anyway, thanks for the response, keep up the good job!
@ttodua, I appreciate you raising these items. (and the notes in the other PRs).
In my opinion, adding settings leads to confusion and a higher risk of users not being able to easily get up and running...
I see this as an opportunity for us to add the hooks into the base plugin to allow for manipulating the data wherever it needs to be changed. Then other plugins can add their own settings or hard code new values or whatever they might need at the time. This would ultimately be more extendable and provide the best experience for users and developers looking to provide customizations for their use-cases.
provide the best experience for users and developers looking to provide customizations for their use-cases.
actually, this is in opposite in our case, as our client(s) can't set on their own and have to ask us (programmers) every time to manually change (which is what we highly distracts). Even, I dont see any argument against it being under 'advanced' tab.
another approach which we used in some our old plugins, was to check like :
if (apply_filters('ZYK_show_extended_settings', false)) { ?>
<input ......... />
<?php
}
to show some form fields in case there was a constant defined or filter (i.e. ZYK_show_extended_settings
) set to true. that might be a possible route in such cases too.
but anyway, it's your plugin and you decide.
regards
ability to hook, instead of hardcoded slug