Open a-laarabi opened 2 years ago
Good job so far! 🌤️ There are some issues that you still need to work on to go to the next project but you are almost there! 🍓
✔️ Great job adding all of the required tasks
[ ] Please add the kanban link in the issue instead of the project link so reviewers can access it with ease
[ ] Kindly ensure that you assign the tasks to each student so they know what they're supposed to work on. One person should get all the tasks for student A and the other for student B. The picture of the assignee will appear in the bottom right of the card once it has been assigned. Also, kindly ensure that the points are equally distributed or not very skewed at the very least when you do assign the tasks. I've added a list of steps below to help you on how to assign tasks
Step 1: Click on a card
Step 2: On the popup that appears on the right, click on assignees and assign a person to the task
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question @zhadier so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
I'm Nemwel your reviewer for this PR :man_beard:
Great job addressing some of the changes that were requested by a previous reviewer :clap: There are some issues that you still need to work on to go to the next project but you are almost there!
Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! :partying_face: 👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @a-laarabi and @tarek102,
Your project is complete! There is nothing else to say other than... it's time to go ahead with the project :shipit: Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Link to the project
GitHub project kanban link
Our team is a team of 2 people.