tarek102 / JavaScript-capstone

In this project we have created a tv list web app, that shows the number of movies and displays info about the movie, you can like or add a comment to each movie. The app was built using 2 API, one is for the tv list and another one for the likes and comments.
1 stars 1 forks source link

JavaScript group capstone: set up the Kanban board #21

Open a-laarabi opened 2 years ago

a-laarabi commented 2 years ago

Link to the project

GitHub project kanban link

Our team is a team of 2 people.

zhadier commented 2 years ago

Hi @a-laarabi & @tarek102 👋

Good job so far! 🌤️ There are some issues that you still need to work on to go to the next project but you are almost there! 🍓

Highlights

✔️ Great job adding all of the required tasks

Required Changes ♻️

Step 1: Click on a card

image

Step 2: On the popup that appears on the right, click on assignees and assign a person to the task

image

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question @zhadier so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Nemwel-Boniface commented 2 years ago

Hello @a-laarabi and @tarek102 :wave: ,

I'm Nemwel your reviewer for this PR :man_beard:

Great job addressing some of the changes that were requested by a previous reviewer :clap: There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️

♻️ Required Changes ♻️

image

Check the comments under the review.

[Optional] suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! :partying_face: 👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 2 years ago

STATUS: APPROVED ✔️ ✔️

Hi @a-laarabi and @tarek102,

Your project is complete! There is nothing else to say other than... it's time to go ahead with the project :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.