search

tarekziade / molotov

Load Testing Tool
Apache License 2.0
450 stars 31 forks source link

Deprecate Python3.7 as it's EOL, upgrade syntax and add support for Python3.12 #153

Closed vinitkumar closed 1 year ago

vinitkumar commented 1 year ago
vinitkumar commented 1 year ago

@tarekziade Please see if all here is fine and let me know if I can change something.

tarekziade commented 1 year ago

Thanks @vinitkumar

vinitkumar commented 1 year ago

Thanks @vinitkumar

@tarekziade Thanks for taking the time to review and approve. Can you please okay the workflow run so that all the Github actions can run and we can sure that the changes work fine?

vinitkumar commented 1 year ago

@n1ngu If you have access to run the CI, can you please approve the workflow run. Thanks :)

n1ngu commented 1 year ago

@n1ngu If you have access to run the CI, can you please approve the workflow run. Thanks :)

@vinitkumar can't do, I am just watching the repo and sharing my thoughts on issues and PRs, but I have no powers whatsoever.

vinitkumar commented 1 year ago

Oh okay. Thanks for letting me know

On Sat, 1 Jul 2023 at 00:23, Ningú @.***> wrote:

@n1ngu https://github.com/n1ngu If you have access to run the CI, can you please approve the workflow run. Thanks :)

@vinitkumar https://github.com/vinitkumar can't do, I am just watching the repo and sharing my thoughts on issues and PRs, but I have no powers whatsoever.

— Reply to this email directly, view it on GitHub https://github.com/tarekziade/molotov/pull/153#issuecomment-1615071176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDITQG7BMORUY6BEX72ILXN4OBTANCNFSM6AAAAAAZWWDAFM . You are receiving this because you were mentioned.Message ID: @.***>

-- -- Thanks and Regards, Vinit Kumar

CHANGER, Raising the bar in Online Experience! +91-8554862210

tarekziade commented 1 year ago

@n1ngu would you like to become a maintainer?

vinitkumar commented 1 year ago

Hi @tarekziade I think I have fixed all the issues with the CI errors. I also got all test and build passing on my fork. So if you can please approve the action run again, you will be able to see it too.

n1ngu commented 1 year ago

@n1ngu would you like to become a maintainer?

Overseeing issues and PRs is something I'll be doing anyway but I'd be glad to help in anything else. Yet, my experience with asyncio is very limited so I'd rely on you doing the same hardwork.

tarekziade commented 1 year ago

Thanks @n1ngu -- adding you as a maintainer

vinitkumar commented 1 year ago

@n1ngu @tarekziade Since all the tests and build pass, do you think it is good enough to be merged now?

tarekziade commented 1 year ago

Thanks @vinitkumar please add yourself to https://github.com/tarekziade/molotov/blob/main/CONTRIBUTORS.rst