Closed Takaaki-Saeki closed 9 months ago
I am grad to hear that this repository will contribute to great ESPNet!
New feature "old Python support" sounds good.
If someone make a pull request, I gladly review it.
Do you have motivation to make the pull request?
Currently SpeechMOS do not implement CI workflow for public pull request.
If you have motivation to make the 'Py3.8 mode' PR, I will quickly prepare the CI workflow, then notify you to 'now we can make a pull request!'
Thank you for the quick response! Then let me send a PR if it's ready :)
We are ready, @Takaaki-Saeki π
Below is a list of repository-wide (not model part) modification points for 'Py3.8 mode'.
Please include below mods.
3.10
in FROM
to 3.8
β Enable development in Python3.8 automaticallytest-py308
job β CI check for Python3.8 automatically runrequires Python=>3.10
to requires Python=>3.8
β Loosen Python version restriction^3.10
of python
to ^3.8
β Loosen Python version restriction Thanks! I will send a PR with changes as you suggested. BTW, I have released a model on my forked repo. The following runs successfully with python 3.8.
predictor = torch.hub.load("Takaaki-Saeki/SpeechMOS:v1.1.0", "utmos22_strong")
Hi, thank you for the great work!
I am now integrating this toolkit to ESPnet through this PR so that many ESPnet users can do pseudo MOS evaluations.
SpeechMOS depends on Python>=3.10, but I think it is desirable to be able to use older python versions if possible. My understanding is that one of the dependencies in python 3.10 comes from this part, because I get the following error when running SpeechMOS with Python 3.8.
This can be avoid by using
typing.List
, instead oflist
as discussed here.Therefore, could you please consider releasing it on
torch.hub
so that it can be used with older Python versions?Thank you again for releasing the great toolkit.