search

tareq1988 / wedocs

A documentation theme for WordPress
http://docs.wedevs.com
394 stars 129 forks source link

Child theming: get_template_directory_uri() vs get_stylesheet_directory_uri() #10

Open Spreeuw opened 9 years ago

Spreeuw commented 9 years ago

I wanted to make a child theme but noticed all stylesheets are exclusively loaded from the main theme by the use of get_template_directory_uri. Is there any specific reason why you don't want to allow overrides of the stylesheets? Using get_stylesheet_directory_uri() instead would solve this and I cannot see any downsides to it... In this aspect it would also help to enqueue the main style.css (with get_stylesheet_directory_uri()): even though you don't use it, it's very convenient for simple overrides and it would follow general wordpress conventions.

I understand that I could just load my own styles on top of yours, but performance wise, overrides can be a better option. Interested to hear your thoughts!

tareq1988 commented 9 years ago

Sorry for replying late.

It was a quick project, so didn't think much. May be a pull request? :)