Bump .NET versions and fix docker build script

tareqimbasher / NetPad

A cross-platform C# editor and playground.

MIT License

1.09k stars 56 forks source link

Bump .NET versions and fix docker build script #213

Open Deliay opened 3 weeks ago

Deliay commented 3 weeks ago

I tried to build a Docker image of NetPad, but it failed. I fixed the Dockerfile and then incidentally upgraded .NET to 8.0 and also upgraded most of the NetPad dependencies to the latest version.

This pull request includes these changes:

Bump .NET to 8.0 and bump almost dependencies to latest version
Fix & enhance docker build script
Support launching the OmniSharp server by dotnet exec OmniSharp.dll due to the container limitation

tareqimbasher commented 2 weeks ago

Thank you @Deliay. A rather large refactor is under way on the solution-refactor branch, including the upgrade to .NET 8. I will hold off on this PR until that is concluded, in a week or so, since it makes large sweeping changes. Once that's done I will revisit the changes introduced here and let you know.

Thanks for the work on the docker script, I haven't really maintained it at all. I appreciate the contribution.

tareqimbasher commented 1 week ago

Update: PR #211 is merged into main. I will be reviewing the changes here soon to see how it needs to change

tareqimbasher commented 6 days ago

@Deliay I requested some changes before merging the PR.

In addition let's hold off on commit (Bump .NET to 8 and bump dependencies to latest version). The package upgrade has a little more to it, especially related to the swagger generated API client. For .NET 8 I want to run some tests on my end to make sure everything still works with that upgrade so I'll go ahead and update to .NET 8 in a later PR once I've validated it. Can you also revert the change to v8 in the README introduced in ac357ba.

Lastly, the change that you introduced in (Support lanuch OmniSharp server via 'dotnet exec OmniSharp.dll') did you test this still works when running the app without docker?