fix: dont log channel url in error message - Githubissues

target / captains-log

A continuous integration plugin that helps organize release information in slack

https://target.github.io/captains-log/

Other

31 stars 4 forks source link

fix: dont log channel url in error message #116

Closed rdmulford closed 3 years ago

rdmulford commented 3 years ago

Description

resolves https://github.com/target/captains-log/issues/115

Motivation and Context

I saw a slack token url secret being logged in CI after a task failed, so wanted to make sure we aren't logging secrets.

How Has This Been Tested?

minor change in logging

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Chore (updating repository quality of life, like deps, linting, etc.)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.