search

target / flottbot-docs

Documentation for flottbot
https://target.github.io/flottbot-docs/
Other
3 stars 7 forks source link

Schedule and multiple flottbot instances #23

Open wass3r opened 6 years ago

wass3r commented 6 years ago

Call out in docs that the scheduler really only works with single bot instances

mackenziegrimes commented 5 years ago

While you're at updating docs, can you update the docs/example rules to have a six-argument cronjob schedule pattern?

In my experience, a bot will run with a second-minute-hour-etc pattern, not minute-hour-etc as the docs mention. Maybe both are supported?

Anyway, the cron library that flottbot uses seems to have 6 args https://github.com/robfig/cron/blob/61d93e07d1be270591d43ede700aa3ae69a2326f/parser.go#L120

wass3r commented 5 years ago

@mackenziegrimes yes, will do. we have a related issue about that here: https://github.com/target/flottbot/issues/20

wass3r commented 4 years ago

it's been a minute, but the lib we're using got an update in the meantime.. i have something in queue to support both patterns, standard and quartz. i'll submit a PR for respective doc edits as well.