Optional args - Githubissues

target / flottbot-docs

Documentation for flottbot

https://target.github.io/flottbot-docs/

Other

3 stars 8 forks source link

Closed wass3r closed 5 years ago

wass3r commented 5 years ago

Closes #28

wass3r commented 5 years ago

Should wait to merge until https://github.com/target/flottbot is tagged.

JordanSussman commented 5 years ago

I think the documentation needs to be updated to clearly state that when referencing optional args you will strip the ?. Specifically https://github.com/target/flottbot-docs/pull/29/files#diff-f7e71ad89c794962825edc299d76dd4bR62 could be confusing to users.

wass3r commented 5 years ago

Yea, I did it in the example but not in the copy. I reworded it now - open to suggestions.

JordanSussman commented 5 years ago

Everything LGTM besides the one minor typo.

wass3r commented 5 years ago

We'll wait to merge until main repo gets tagged as mentioned previously

wass3r commented 5 years ago