target / goalert

Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert
https://goalert.me
Apache License 2.0
2.24k stars 244 forks source link

twilio number lookup: handle when twilio is unconfigured #1220

Open Forfold opened 3 years ago

Forfold commented 3 years ago

Is your feature request related to a problem? Please describe: When Twilio is not configured, the Twilio Number Lookup form (located at /admin/toolbox) can still be used and will return an unknown error when submitting.

Describe the solution you'd like:

dctalbot commented 3 years ago

Another option, especially if we think we'll have more utilities on this page in the future, is something like <Accordion title="Twilio" caption={!twilioEnabled && "Disabled"} disabled={!twilioEnabled} /> similar to our "admin config" page

Screen Shot 2021-01-27 at 3 50 55 PM

But this is also essentially hiding the content, which I agree isn't ideal.

Forfold commented 3 years ago

Good point, we could also do something like "Twilio Tools" and have all the cards with Twilio forms under that. It may feel a bit redundant with the two forms we have now, but yeah I definitely agree that it's a good option if we foresee adding more in the future

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity.