ui/tech-debt: JSX.Element has been deprecated

[Forfold]

We'll need to rethink our component typings, as JSX as a whole has been deprecated in favor of React.JSX.

This is a good opportunity to decide if we want all of our components to be one of:

• React.JSX
• React.ReactNode (allows null, may be most preferred to work well with Suspense down the road)
• React.FC

[mastercactapus]

I think ReactNode is the preferred way and what we intended JSX to be used for

[Forfold]

Agreed, I would be fine with moving towards ReactNode from the top down

[Kamlesh72]

@Forfold is this issue beginner friendly?

[Forfold]

Yes and no. It doesn't require a ton of effort, but it's a bit of a spiderweb in that I've noticed if I flip certain files to ReactNode from JSX.Element it freaks out saying it's not expected. So I think we need to start with the components at the highest level

[Kamlesh72]

Yes and no. It doesn't require a ton of effort, but it's a bit of a spiderweb in that I've noticed if I flip certain files to ReactNode from JSX.Element it freaks out saying it's not expected. So I think we need to start with the components at the highest level

Got it @Forfold. Seems moderate level. Waiting for your PR 😃