target / goalert

Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert
https://goalert.me
Apache License 2.0
2.17k stars 229 forks source link

engine/statusmgr: Fix status update on missing log #3788

Closed mastercactapus closed 3 months ago

mastercactapus commented 3 months ago

Description: Fixes an issue where status updates can get "stuck" if the log entry is missing/invalid.

This was fixed by removing the fkey constraint on outgoing messages (recording the log ID as zero) and including fallback text based on the current alert status.

Which issue(s) this PR fixes: Fixes #3783

Screenshots:

Example of missing log message: Screenshot_20240402_124123

mastercactapus commented 3 months ago

Closing to take a different approach to resolving this issue