target / goalert

Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert
https://goalert.me
Apache License 2.0
2.17k stars 230 forks source link

User Profile Access Denied when Exceeding Contact Method Limit #3869

Closed mastercactapus closed 1 month ago

mastercactapus commented 1 month ago

Describe the Bug: Adding too many contact methods (at or below the system limit) results in an "access denied: exceeded auth check limit" error. This error not only affects the user performing the operations, but it also prevents other users from accessing that user's profile page to possibly rectify the error.

Steps to Reproduce:

  1. Go to User Profile Page
  2. Add contact methods until reaching or falling below the default system limit
  3. Attempt to view or edit user's profile
  4. See error "access denied: exceeded auth check limit"

Expected Behavior: A user should be able to add contact methods up to the default system limit without encountering an error. Otherwise, users should be able to access the problematic user's profile page to manage the issue.

Observed Behavior: At or below the system limit for contact methods, users receive an "access denied: exceeded auth check limit" error and can no longer view or edit that user's profile. This error also affects other users who attempt to view or manage the problematic user's profile.

Potential Solutions: Consider optimizing the GraphQL layer as the error might indicate that a fetch call isn't being batched as it should be. Alternatively, ensure the UI can render at least some data to allow for essential user profile functions other than contact methods. This could localize the error to the contact method card, allowing for better resolution options.

Application Version: This affects master

Additional Context: As a workaround, admins can delete the user or directly connect to the DB for resolution.

mastercactapus commented 1 month ago

Replaced with #3870 contact methods were not the issue