search

target / goalert

Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert
https://goalert.me
Apache License 2.0
2.17k stars 230 forks source link

tech debt: deprecate stepNumber, use stepIndex #3872

Closed Forfold closed 1 week ago

Forfold commented 1 month ago

We've noticed that the stepNumber is used throughout the backend with an index of 0, and on the UI a stepNumber + 1 is being rendered.

We think that stepNumber would be best beginning at 1 from the backend, but since this name is already in use we have decided on deprecating stepNumber and using stepIndex moving forward, while keeping the index starting with 0. This will help keep GoAlert backwards compatible.

c0d33ngr commented 1 week ago

I'll take this

Forfold commented 1 week ago

Whoops, I fixed this already but forgot to mark this as completed. Are you looking at good first issues to pickup @c0d33ngr?

Forfold commented 1 week ago

Addressed with https://github.com/target/goalert/pull/3916